Dmitry Pasiukevich
Dmitry Pasiukevich
/gemini review
I will try do a proper review tomorrow. Thank you for the contribution!
Definitely, we'd need to improve it here. * I've sent https://github.com/google/adk-go/pull/286. * After that PR is merged, I will add Issue templates for Bug, Feature, Blank Issue and Security Vuln....
Thanks for volunteering! Vertex AI session service implementiation is WIP https://github.com/google/adk-go/pull/235
Let me actually keep the issue open for visibility until https://github.com/google/adk-go/pull/235 is merged.
Also we need to make sure we have a clear documentation for a functiontool about what happens to error and when and what types of error should be in the...
It seems as @baptmont found we need to return an error string to llm `err.Error()`, otherwise if it's a pointer it won't read the error message.
> It seems as @baptmont found we need to return an error string to llm `err.Error()`, otherwise if it's a pointer it won't read the error message. Opened https://github.com/google/adk-go/issues/278 for...
What do you think should be the alternative? IMO having two implementations is adk-go covers the whole spectrum of user needs: * vertex ai session service -- free saas *...
`maps` are also supported right now. Restricting validation to a struct only, that will break function tools that use maps: `updateUserPreference(ctx tool.Context, args map[string]string) (map[string]string, error)`