Dmitry Pasiukevich

Results 70 comments of Dmitry Pasiukevich

@imrenagi thanks for the feedback! Could you clarify what do you mean by "hard dependency in a library" here? ADK core library is decoupled, it only requires `session.Service` interface implementation....

@shanipribadi that's a good summary, thanks! Moreover, the session service functional requirements are quite basic: simple read/writes, some wrapped in a transaction. I don't expect GORM to be problematic here...

Regarding exposing gorm DB type in the database provider (or some subset of it), this definitely makes sense and we'd follow up on this. Thanks!

@shanipribadi hi, we've added the `AutoMigrate` func helper https://github.com/google/adk-go/pull/241 to allow init tables. As for exposing gorm.DB and/or go structs defining the tables, I'd like to keep them internal as...

LGTM! Let me know if you'd like to update this PR to hide restapi entities and expose only `NewHandler(config *launcher.Config) http.Handler`

Definitely! I also wanted to take a proper look and update/improve the launcher package if there'd be any ideas from my side. `Config` is one of such examples.

@appleboy it should be possible to merge yourself, you only needed to mark comments as resolved. Let me know if that was not the case.

> it does not seem like we can use these vendors with adk-go Could you share, why do you have these concerns? This is a go library and you could...

Thanks for clarification! OpenAI model support is being worked on https://github.com/google/adk-go/pull/242 (it's pending review for now).

https://github.com/go-a2a is a private org unrelated to us. @zchee I see https://github.com/go-a2a/adk-go and the work on it is really impressive! It would've been quite cool if we could combine the...