Dmitry Pasiukevich

Results 70 comments of Dmitry Pasiukevich

For example if we have this go func `func updateUserPreference(ctx tool.Context, args map[string]string) (*updateUserPreferenceResult, error) { ... }` This will generate the following jsonschema for input ``` { "parametersJsonSchema": {...

> So, should I relax the input validation by allowing the map type? Yes, we should allow anything which jsonschema-go converts to json object (only maps and structs come to...

We've released v0.2.0 on Friday and the docs are updated in https://github.com/google/adk-docs/pull/967

> 1. What is the measured impact of a coredns daemonset querying pods on the API server? I know that Zalando is using a [coredns daemonset](https://github.com/zalando-incubator/kubernetes-on-aws/blob/dev/cluster/manifests/coredns-local/daemonset-coredns.yaml) and i'm pretty sure...

1. That's just the estimation. I don't expect there were any scalability benchmarks to see the API server performance and requested resources depending on the size of daemonset and frequency/size...

@Arjunmehta312 could you also update the example to pass the linter and we're good to merge.

@sjzsdu thanks for contribution! Before we'd start the PR review, could you fix 2 main issues: 1. The imports got changed to `github.com/sjzsdu/adk-go`. It should be `google.golang.org/adk`. 2. Could you...

The main intention to avoid exposing context creation functions publicly. This should not be a part of the public API: * ADK users should not be able to create the...

That's too late unfortunately, `v0.2.0` tag is released already. I'm exploring a way to automate this. This field should be updated with a new value exactly before we cut a...

Thanks for raising this! I believe we should solve 2 issues here: 1. As pointed in https://github.com/google/adk-go/pull/406 PR, the session is created using the request-scoped context passed to Tools(ctx). 2....