adk-go icon indicating copy to clipboard operation
adk-go copied to clipboard

Consider moving gorm to adk-go-community repository

Open rakyll opened this issue 3 weeks ago • 4 comments

There is a gorm integration underneath the session/database package.

  • Third party ecosystem integrations should be provided from the community repo, adk-go-community.
  • The package shouldn't be called database, but a gorm package. database is too broad.

@dpasiukevich, any thoughts?

rakyll avatar Nov 13 '25 04:11 rakyll

An earlier discussion is available on this topic, https://github.com/google/adk-go/issues/236. Closing this issue because all ADK implementations need a OSS database integration and it's provided via gorm.

rakyll avatar Nov 13 '25 04:11 rakyll

Apparently, it's still useful to discuss this option and I shouldn't close this issue right now. I'm reopening so we can discuss it.

rakyll avatar Nov 13 '25 06:11 rakyll

What do you think should be the alternative?

IMO having two implementations is adk-go covers the whole spectrum of user needs:

  • vertex ai session service -- free saas
  • gorm-based -- easy to start generic solution for on-premises DBs.
  • inmemory -- for dev/test/experiments

And if users would ask for specific db implementations (e.g. postgresql using database/sql, optimized and written specifically for postgres), such things would go to go-adk-community.

dpasiukevich avatar Nov 13 '25 09:11 dpasiukevich

I'm new to this project, so take this with any grains of salt you wish

@dpasiukevich's outline seems reasonable. I'd like to be able to have an easy path to self hosted sessions & memory without losing it between runs / builds (including during development), while in-memory seems most useful for examples

verdverm avatar Nov 13 '25 23:11 verdverm