Dmitry Pasiukevich
Dmitry Pasiukevich
Yes, there's also https://github.com/modelcontextprotocol/go-sdk/pull/719 as well which exposes ErrSessionMissing. And I see there's already exposed `mcp.ErrConnectionClosed`. Folks WDYT if we'd follow this approach: MCPToolset right now calls `session.ListTools` and `session.CallTool`....
I did some experiments. Seems like `errors.Is(err, mcp.ErrConnectionClosed)` is handling this (either when client's context is cancelled or server terminates the session).
I don't think there's problem with request-scoped context. Because this context is only needed to create a session. Once session object is created even if the context is cancelled it...
What if we do this conversion to miliseconds only in the applyEvent()? ``` if storageUpdateTime > sessionUpdateTime { return fmt.Errorf("stale session error: ...") } ``` This way we will support...
Honestly, I don't like the idea to have millisecond precision. If there are 2 agents working on the same session (e.g. main and sub agent), and they generated 2 events...
The bumping precision example: https://github.com/google/adk-go/compare/main...dpasiukevich:adk-go:db_session_precision @huangbug could you check if this looks good?
Correct. I've created a branch with the required changes: https://github.com/google/adk-go/compare/main...dpasiukevich:adk-go:db_session_precision 1. It has `gorm:"precision:6"` for time.Time type for all entities. So now mysql driver should create datetime(6) with microsecond precision....
@huangbug I've added https://github.com/google/adk-go/pull/414 to explicitly set microsecond level precision. Thank you for noticing this!
Thanks for the PR! I'm thinking -- now we will always be making 2 network requests: ping + list/call_tool. What do you think about these approaches: 1. Making a detached...
> @team could you please assign this issue to me? I love to contribute. Assigned, thanks for help!