dan sinclair

Results 219 comments of dan sinclair

This seems more like a VS issue then a shaderc issue. I'd be hesitant to change the format being emitted because we don't know if anything is depending on that...

Apps are able to override any `override` value in the shader, that's what they're for, so they can be set from the application side. I'm not sure what you mean,...

You don't need `publicBinding` to set them in JS code, we'd just need to make them able to take an `override` and then you could override from the JS.

Library authors can do as they wish, if they want to use a constant value, they can. If they wanted to use an override, they can do that as well....

This sounds like an issue in the Firefox implementation. I'd suggest filing a bug against Firefox.

Is it possible to add a spec test for this case so we can make sure it doesn't creap back into the code?

Hm, I've been looking but can't find the documentation for license-check. I also don't have admin, and am unable to ignore the check. @dneto0 do you have the ability to...

The handling of space is done by the preprocessor, the output of the preprocessor is a token stream. So, the definition of what is a space character is in the...

I'm not sure if this is worthwhile, seems like a fairly minor use case that you want to start the index one off where you actually start it?