dan sinclair
dan sinclair
I'm fine leaving the access_mode, etc, but I think the argument still stands for the various attributes. I'm not a fan of the concise attributes for reasons similar to the...
This generalized form is what we have in Tint now and we've been receiving reports from folks using the language that they hit issues like a variable `position` causing `@builtin(position)`...
I'm not sure I see the issue with having the more specific syntax. Downstream tools can handle it as well as they can a super generalized syntax, and it provides...
The attributes aren't the only place that potentially needs to change in the spec for extensions and future values. If we add a new integer character like we have for...
It seems like `arrayLength(colour)` would best fit with what we have currently, then it matches the runtime `arrayLength` call. Having to call it one way for runtime and a different...
It's the inconsistency that I don't really like. There are a lot of edge cases around sharing `arrayLength`, and there are edge cases around `typeof` for how we spec it....
Would this be scalars only, or would it include literals? Could I do `1.xxxx`? If so, that makes parsing slightly more complex as you don't know if `1.` is a...
I don't believe you need a google account. In order to accept the contribution you'll need to go to https://cla.developers.google.com/ and sign the CLA.
Yea, turns out I was wrong, from the FAQ on that page `A Google account is required to sign the CLA.` As far as I can see, there is no...
The code looks good to me. Once the CLA is sorted out I think this is good to go.