dan sinclair comments

Results 219 comments of


                                            dan sinclair

limit the overrides in the shader interface, to those that are "statically accessed"

Is there a test that can be written for this? If we use the override it's accessed .... if we don't use it, how do we test that it wasn't...

limit the overrides in the shader interface, to those that are "statically accessed"

Obsolete

wgsl: validate struct parsing

* Size tests https://github.com/gpuweb/cts/blob/main/src/webgpu/shader/validation/shader_io/size.spec.ts * Align tests https://github.com/gpuweb/cts/blob/main/src/webgpu/shader/validation/parse/align.spec.ts * Struct tests https://github.com/gpuweb/cts/blob/main/src/webgpu/shader/validation/types/struct.spec.ts

wgsl: execution tests for textureDimensions builtin

The majority of this is complete. The missing piece is to add testing of `textureDimensions` with a `texture_external` texture.

wgsl: validate all arithmetic operations fail if one of the types is an atomic.

Add is tested in https://github.com/gpuweb/cts/blob/main/src/webgpu/shader/validation/types/atomics.spec.ts others should probably be tested as well.

wgsl: validate parsing of type aliases

https://github.com/gpuweb/cts/blob/main/src/webgpu/shader/validation/types/alias.spec.ts

wgsl: validate parsing or storage texture types

https://github.com/gpuweb/cts/blob/main/src/webgpu/shader/validation/types/textures.spec.ts

wgsl: validate parsing of sampled texture types

https://github.com/gpuweb/cts/blob/main/src/webgpu/shader/validation/types/textures.spec.ts

wgsl: Validate variable and value declaration parsing

* https://github.com/gpuweb/cts/blob/main/src/webgpu/shader/validation/decl/var.spec.ts * https://github.com/gpuweb/cts/blob/main/src/webgpu/shader/validation/decl/let.spec.ts * https://github.com/gpuweb/cts/blob/main/src/webgpu/shader/validation/parse/var_and_let.spec.ts * https://github.com/gpuweb/cts/blob/main/src/webgpu/shader/validation/decl/const.spec.ts * https://github.com/gpuweb/cts/blob/main/src/webgpu/shader/validation/decl/override.spec.ts

should test use of implicit derivatives in point rasterization mode

@jrprice will this be covered by the derivative tests you've been adding?