dan sinclair
dan sinclair
kokoro:run
Something has gone strange with the bots and they're failing to compile in, it looks like, swiftshader? I'm going to put up a CL and see if I can figure...
I'm still working on the bots. Needs to have dependencies updated but getting all of them to the right versions is proving difficult. https://github.com/google/amber/pull/1037 is my work in progress CL,...
Ok, if you can rebase this on top of main, I fixed up the various bot issues and got a green build and landed it.
The script expects to find `clang-format` on your path, so you'll need clang-format somewhere. (The script is just a thin wrapper around clang-format to call it for the various folders,...
Are there other pipeline flags we may want to set? Having it `FLAGS LIBRARY` may make more sense in that case.
Fixed, needed to associate the email github picked with my account. Is this ready for me to do another round of reviews?
They all passed with the DeviceProperties CL, and with my fixup CL. So, it seems like something in this PR is causing the failures.
Merged. Thank you very much for the design, implementation, and patience as we worked through the bot issues. Very much appreciate the contribution.
There are precedence tests in https://github.com/gpuweb/cts/blob/main/src/webgpu/shader/execution/expression/precedence.spec.ts but it looks like `.member` and `[]` aren't covered yet.