api icon indicating copy to clipboard operation
api copied to clipboard

operator/v1: Move KubeScheduler CRD to run-level 50

Open wking opened this issue 2 years ago • 6 comments

The outgoing level 25 is from openshift/cluster-kube-scheduler-operator@530e585f63 (openshift/cluster-kube-scheduler-operator#118). But while it makes sense to want a scheduler early so that later pods can get scheduled, cluster bootstrapping and other outgoing clusters already have a scheduler in place. For example, you need a functional scheduler, Deployment controller, and ReplicaSet controller to roll out the scheduler operator. By consolidating in the highly-parallel default level 50, we allow for some time savings (especially once we shift kube-controller-manager-operator from 25 to 50 as well, which I plan on doing next).

wking avatar Sep 27 '23 11:09 wking

Hello @wking! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] avatar Sep 27 '23 11:09 openshift-ci[bot]

Scheduler should install and update before any other component so that new scheduling techniques can be used.

/hold

deads2k avatar Sep 27 '23 13:09 deads2k

other pieces need to be updated, but this looks reasonable

/approve

deads2k avatar Sep 27 '23 13:09 deads2k

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 27 '23 13:09 openshift-ci[bot]

@wking: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration d8fbe5b5c60ea095b5ab48a1f0ecd37efb0bb652 link true /test integration
ci/prow/verify-crd-schema d8fbe5b5c60ea095b5ab48a1f0ecd37efb0bb652 link true /test verify-crd-schema
ci/prow/e2e-aws-serial-techpreview d8fbe5b5c60ea095b5ab48a1f0ecd37efb0bb652 link true /test e2e-aws-serial-techpreview
ci/prow/e2e-upgrade-minor d8fbe5b5c60ea095b5ab48a1f0ecd37efb0bb652 link true /test e2e-upgrade-minor

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Mar 19 '24 13:03 openshift-ci[bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Jun 18 '24 09:06 openshift-bot

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Aug 11 '24 00:08 openshift-bot

@wking: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration d8fbe5b5c60ea095b5ab48a1f0ecd37efb0bb652 link true /test integration
ci/prow/verify-crd-schema d8fbe5b5c60ea095b5ab48a1f0ecd37efb0bb652 link true /test verify-crd-schema
ci/prow/e2e-aws-serial-techpreview d8fbe5b5c60ea095b5ab48a1f0ecd37efb0bb652 link true /test e2e-aws-serial-techpreview
ci/prow/e2e-aws-ovn-techpreview d8fbe5b5c60ea095b5ab48a1f0ecd37efb0bb652 link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-upgrade-minor d8fbe5b5c60ea095b5ab48a1f0ecd37efb0bb652 link true /test e2e-upgrade-minor
ci/prow/e2e-aws-ovn d8fbe5b5c60ea095b5ab48a1f0ecd37efb0bb652 link true /test e2e-aws-ovn
ci/prow/e2e-aws-ovn-hypershift d8fbe5b5c60ea095b5ab48a1f0ecd37efb0bb652 link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-upgrade d8fbe5b5c60ea095b5ab48a1f0ecd37efb0bb652 link true /test e2e-upgrade
ci/prow/e2e-aws-serial d8fbe5b5c60ea095b5ab48a1f0ecd37efb0bb652 link true /test e2e-aws-serial
ci/prow/minor-e2e-upgrade-minor d8fbe5b5c60ea095b5ab48a1f0ecd37efb0bb652 link true /test minor-e2e-upgrade-minor
ci/prow/minor-images d8fbe5b5c60ea095b5ab48a1f0ecd37efb0bb652 link true /test minor-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 15 '24 15:08 openshift-ci[bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-bot avatar Sep 15 '24 08:09 openshift-bot

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Sep 15 '24 08:09 openshift-ci[bot]