kubernetes
KEP-3488: add spec for supporting custom match criteria
Signed-off-by: Max Smythe [email protected]
- One-line PR description: Add spec for supporting custom match criteria
- Issue link: https://github.com/kubernetes/enhancements/issues/3488
- Other comments:
Welcome @maxsmythe!
It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/enhancements has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @maxsmythe. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
- @tallclair for the idea of CEL based match rules like those proposed here eventually being made available for admission webhooks as well
/assign @deads2k @lavalamp
This is roughly the pre-filter mechanism as https://github.com/kubernetes/enhancements/pull/3717 except for ValidatingAdmissionPolicy instead of ValidatingWebhookConfiguration
As long as this approach follows the equivalent webhook feature in terms of supported functions and the like, this looks ok to me. I see why parameters were included in this variant, but before taking it to beta I'd like to know how well parameters at this level are working out in alpha since that will be the only difference with the webhook variant.
/approve /assign @jpbetz @lavalamp
leaving lgtm with Joe or Daniel
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: deads2k, maxsmythe
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~keps/sig-api-machinery/OWNERS~~ [deads2k]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/lgtm Thanks for keeping this aligned with https://github.com/kubernetes/enhancements/pull/3717 !