enhancements
enhancements copied to clipboard
kubernetes
Add soltysh to prod-readiness-approvers
Shadow contribution summary:
Planned future involvement:
- 1.31+ I'm planning to continue my contributions to PRR, hopefully reaching 10 KEPs/release cycle, aside from the ones I'm looking at as sig apps and sig cli lead.
Shadow reviewer promotion criteria:
Transitions from new to alpha
- https://github.com/kubernetes/enhancements/pull/4211 (sig-node)
- https://github.com/kubernetes/enhancements/pull/3927 (sig-auth)
- https://github.com/kubernetes/enhancements/pull/4230 (sig-node)
- https://github.com/kubernetes/enhancements/pull/3824 (sig-network)
- https://github.com/kubernetes/enhancements/pull/3067 (sig-node)
- https://github.com/kubernetes/enhancements/pull/4184 (sig-node)
Transitions from alpha to beta
- https://github.com/kubernetes/enhancements/pull/4256 (sig-scheduling)
- https://github.com/kubernetes/enhancements/pull/4219 (sig-instrumentation)
- https://github.com/kubernetes/enhancements/pull/4397 (sig-storage)
- https://github.com/kubernetes/enhancements/pull/4470 (sig-auth)
- https://github.com/kubernetes/enhancements/pull/4288 (sig-node)
Transitions from beta to GA
- https://github.com/kubernetes/enhancements/pull/4407 (sig-storage)
- https://github.com/kubernetes/enhancements/pull/4472 (sig-apimachinery)
- https://github.com/kubernetes/enhancements/pull/4432 (sig-storage)
Must have successfully reviewed at least three enhancements that require coordination between multiple components.
- https://github.com/kubernetes/enhancements/pull/4230 (kubelet-cadvisor-cri)
- https://github.com/kubernetes/enhancements/pull/3824 (kube-proxy-linux kernel)
- https://github.com/kubernetes/enhancements/pull/4266 (kube-apiserver kubelet cri)
- https://github.com/kubernetes/enhancements/pull/4288 (kubelet cri)
Must have successfully reviewed at least three enhancements that require version skew consideration (both HA and component skew): does behavior fail safely and eventually reconcile.
- https://github.com/kubernetes/enhancements/pull/3824 (switching kube-proxy from iptables to nftables)
- https://github.com/kubernetes/enhancements/pull/4256 (requeuing improvements in scheduler)
- https://github.com/kubernetes/enhancements/pull/3067 (sub-second probes)
- https://github.com/kubernetes/enhancements/pull/4184 (grpc endpoint in kubelet)
- https://github.com/kubernetes/enhancements/pull/4472 (aggregated discovery)
- https://github.com/kubernetes/enhancements/pull/4470 (bound service account tokens improvements)
Must have successfully reviewed at least three enhancements that are outside your primary domain.
- https://github.com/kubernetes/enhancements/pull/4211 (sig-node)
- https://github.com/kubernetes/enhancements/pull/4230 (sig-node)
- https://github.com/kubernetes/enhancements/pull/3824 (sig-network)
- https://github.com/kubernetes/enhancements/pull/4256 (sig-scheduling)
- https://github.com/kubernetes/enhancements/pull/3067 (sig-node)
- https://github.com/kubernetes/enhancements/pull/4082 (sig-storage)
- https://github.com/kubernetes/enhancements/pull/4184 (sig-node)
- https://github.com/kubernetes/enhancements/pull/4219 (sig-instrumentation)
- https://github.com/kubernetes/enhancements/pull/4397 (sig-storage)
- https://github.com/kubernetes/enhancements/pull/4470 (sig-auth)
Examples where the feature requires considering the case of administering thousands of clusters. This comes up frequently for host-based features in storage, node, or networking.
- https://github.com/kubernetes/enhancements/pull/3824 (switching kube-proxy from iptables to nftables)
- https://github.com/kubernetes/enhancements/pull/4184 (grpc endpoint in kubelet)
- https://github.com/kubernetes/enhancements/pull/4397 (pv reclaim policy)
Examples where the feature requires considering the case of very large clusters. This is commonly covered by metrics.
- https://github.com/kubernetes/enhancements/pull/4256 (pod scheduling SLO)
- https://github.com/kubernetes/enhancements/pull/3067 (sub-second probes)
- https://github.com/kubernetes/enhancements/pull/4184 (grpc endpoint in kubelet)
- https://github.com/kubernetes/enhancements/pull/4407 (pod topology spread)
- https://github.com/kubernetes/enhancements/pull/4397 (pv reclaim policy)
Thanks @soltysh! I appreciate all your work on PRR thus far!
I spot checked the reviews and they appear to meet our criteria. I'll defer to the tenured PRR reviewers for decision making on this one.
I'm supportive.
@deads2k @johnbelamaric - we probably need one more vote from one of you :)
I'm supportive.
@deads2k @johnbelamaric - we probably need one more vote from one of you :)
me too.
/lgtm /hold
holding for @johnbelamaric
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: johnbelamaric, soltysh
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
- ~~OWNERS~~ [johnbelamaric]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
