Daniel Cousens

Results 527 comments of Daniel Cousens
trafficstars

@joshuapinter I like it. It also easily allows for language extensions if anyone ever needs it. PR accepted, as `2.0.0`

Any further work on this? I'm currently trying to use `blanket` like this: ``` mocha --compilers js:babel/register --require blanket ``` And naturally `esprima` is exploding pretty quickly.

In https://github.com/bitcoinjs/bech32, we [`.toLowerCase()`](https://github.com/bitcoinjs/bech32/blob/master/index.js#L43) the HRP.

@9001-Sols why aren't you using `node_modules`?

Will inspect this soon :+1:

I think we might have to languish in the fact that we added this feature knowing that this could be a risk. No free lunch. Thanks for this pull request...

@juangl as first step, we probably need a benchmark to compare this against the existing code - some questions might appear if the benchmark is severely impacted

Following the history, numbers are [explicitly supported in the code](https://github.com/JedWatson/classnames/blob/master/index.js#L22-L23) since https://github.com/JedWatson/classnames/pull/8. I concur they don't make sense, maybe they could be useful in the `bind` variation? Removing them now...

Removing `number` now is a breaking change, but, I don't think we'd risk the problem of being too opinionated by removing type `number` from the acceptable types in the next...

> The problem only occurs after we run our code through our build pipeline which uses Rollup/Babel to produce a CJS bundle so we can render server-side. Do you mean...