Daniel Cousens comments

Results 551 comments of


                                            Daniel Cousens

trafficstars

First idea of "confirmation layer"

@runn1ng I commented on the commit directly. Nice work! Mostly nits. I think we're going to have 3 user-choices. * UTXO priority order * UTXO selection algorithm * Output selection...

First idea of "confirmation layer"

Maybe also add an example of how BNB fits into this

First idea of "confirmation layer"

I simply haven't had time to review/discuss this yet :frowning: - apologies @runn1ng

First idea of "confirmation layer"

@karel-3d reading this again, I still don't know if this is the right space. Isn't the optimal behaviour around confirmations entirely contextually dependent? Many users may **always** want 6+ confirmations,...

Adding Branch and Bound algorithm

Sorry for the delay here, reading now.

Adding Branch and Bound algorithm

Looks good to me, at least for merge/ongoing research/testing :) - not for release until everything is tested though.

Adding Branch and Bound algorithm

@runn1ng if the fee has no meaningful result, maybe `NaN`?

Adding Moneypot simulation

LGTM, will merge after nit then play with it locally

Adding Moneypot simulation

> should I do that in this PR or separately ignore for now, I'll find out post-merge

Adding Moneypot simulation

> I kinda like the idea of "waiting until there is enough balance", if not exactly how the other repo is doing it, since that simulates user's behavior more. Agreed,...