Daniel Cousens

Results 527 comments of Daniel Cousens
trafficstars

Additional breaking change request: - [ ] `assert(str.length % 2 === 0)` for base16/hex

@indutny yes, but, is `andln` useful? It only works on the first word? > -1 for hex padding. This is going to be hell of a breaking change. I know......

> Maybe we can make it throw for just hex, and accept without padding for base-16? That sounds reasonable.

> I can submit a pull request to fix this issue. @macor161 please do! But if you don't have time, please please submit a failing test :+1:

@indutny any insight here?

You should be able to exclude `Buffer` to no ill-affect, the `require` is wrapped in a try catch and is only done lazily if necessary.

@SilentCicero except for those of us that use `Buffer` everywhere in crypto.

> UInt8Arrays You know that is what a `Buffer` is?

@SilentCicero `Buffer` is quite literally `UInt8Array`, [see here](https://github.com/feross/buffer/blob/master/index.js#L62). The difference is the added methods for serialization and conversion to avoid re-implementations popping up everywhere that almost always lead to bugs....

@indutny actually, that simply disables it out-right for all browserify users... even if `buffer` is imported elsewhere in your bundle. It removes it from the dependency chain for `bn.js` so...