Daniel Cousens

Results 527 comments of Daniel Cousens
trafficstars

@axic ceiling? or towards `0` for negatives?

@axic what is left to do here? Do you have time?

I really should get cracking on https://github.com/indutny/bn.js/pull/36

Padding is typically dealt with at a byte level, the issue of toString doing any padding at all is confusing.

Keep open as debt or close? Someone can always open a PR if necessary.

ACK, sounds good to me. I'll happily put the time in bumping some of the crypto-browserify packages up to the new changes.

> Maybe at that stage two's complement could be made more internal (part of constructor and toString) (see #73) Did we want to elaborate more on what this change might...

@axic how do you use `toTwos/fromTwos` to parse a DER integer?

@indutny if you don't intend to change `modn` to return a BN, I'd remove it. Changing it is additionally dangerous for existing users who blindly upgrade, so removing is the...

> I don't mind naming it modln instead of modrn, and mentioning it in the docs. Would you care to open a PR? I suppose, but what did `ln` mean?...