Daniel Cousens

Results 530 comments of Daniel Cousens
trafficstars

Maybe it would be only write to `.keystone/admin/next.config.js` if something like `config.ui.writeNextConfig !== false`? Or similar? Users can then do whatever they want?

OK, this pull request is superseded by #9186

Actually @gautamsi, #9186 is a breaking change, maybe we can land this earlier?

Yes, but I don't have time to test this particular pull request before then - can you?

That's fair, and I'm thinking about how maybe we can balance the best of both. I'll mark this as draft for now, unless you only wanted me to drop ce6edea?

@Foxboron I think I have made the changes requested, should be good for review

I additionally added [d45fd23](https://github.com/Foxboron/ssh-tpm-agent/pull/57/commits/d45fd23b0a2cd1daf925ebb29aef91792728b23e), which seems to be different - I can drop that if needed

Doesn't appear to be resolved ```bash # ssh-tpm-keygen -f test # and added test.pub to authorized keys $ git rev-parse HEAD 54a466a8eec3b48b374e05908dfa11b112392c30 $ ./bin/ssh-tpm-agent -d time=2024-07-14T10:16:44.485+10:00 level=INFO msg="Warning: ssh-tpm-agent is...

Interesting! I'll try and automate a reproduction when I can

If desired, I can split this up into two different pull requests, fixes and new copy