Daniel Cousens

Results 527 comments of Daniel Cousens
trafficstars

@indutny I am not against using a `require('bn.js/buffer')` like import to get `Buffer` in there if it drops the dep in areas where it unnecessary. Breaking change obviously.

@odra don't include the `npm build`, typically the maintainer will do it anyway and its a security issue

Rebase or close?

@SethArchambault interesting question! The changes in https://github.com/dcousens/haversine-distance/commit/e34e79350720edfb86f0f6fd3f0bc982c1f17f0d were from a small exercise I made for myself in understanding the underlying math and rewriting the implementation from scratch in a way...

@SethArchambault rather than debating implementations, do we have any reference vectors we can lean towards? I'm thinking with accuracy down to 12+ decimal places. I haven't the time to verify...

@chriscalo thanks for the PR! This change incidentally adds a blind spot for developers though, in that, they can pass a string which doesn't `parseInt` to a finite `number`. Granted,...

> The error of passing a string that parses to a non-finite number is still caught because the same validations run as before: Yes, but, now an `error` or (`return...

@joshuapinter I suppose, what is the usecase/advantage though?

`indicator` is truly a terrible name, it is more a "suffix-only" option - alas this API was mimicking the previous versions of this module (which I inherited from someone else)....