Derek Bailey

Results 273 comments of Derek Bailey

This should be updated now to 2.0.7: https://search.maven.org/artifact/com.google.flatbuffers/flatbuffers-java/2.0.7/bundle @taroplus Can you try using this? I am not a Java developer, so I am not the best person to test it.

@rileylyman Any desire to continue with this?

Closing for now, feel free to reopen.

It seems the String generated code is not correct, I'm not sure why it is comparing Ushort values when it should be comparing strings: https://github.com/google/flatbuffers/blob/8d1cc6ac7d9c750fef41f01012726a7d431be589/src/idl_gen_csharp.cpp#L625-L639 Could you give the schema...

It appears the issue is due to having a key == 0. If I set the keys to [1,2,3,4] everything works. Looking into this more.

Ah, I remember this from the Java implementation, the default value for the `IntItem.id` is 0, and we don't push default values into the buffer unless 'ForceDefaults' is enabled. So...

This is leading to a bigger bug :( If you leave your code as is, and just change `AddCount(fbb, i+1)` it works. That's because, if any of the `IntItem` fields...

@CasperN If you update it, I can review it now.

@CasperN Ready to revive?