flatbuffers icon indicating copy to clipboard operation
flatbuffers copied to clipboard

Published 20 hours ago • verified publisher icon google

Namer TS

Open CasperN opened this issue 2 years ago • 1 comments

Apply Namer to typescript code generation #7142

CasperN avatar Apr 27 '22 04:04 CasperN

Interesting bug / edge case in the last commit:

reflection.fbs generated Object_T instead of ObjectT because Object is a keyword and we escaped keywords before adding object prefix and suffix. The previous implementation never escaped object-api names, which assumes no JS keyword would ever end in T (or match whatever user defined prefix/suffix is provided). I fixed this by making escaping happen after prefixing/suffixing but this is a subtle behavior change that affects all languages.

CasperN avatar Apr 28 '22 04:04 CasperN

@CasperN If you update it, I can review it now.

dbaileychess avatar Aug 06 '22 05:08 dbaileychess

@CasperN Ready to revive?

dbaileychess avatar Aug 27 '22 17:08 dbaileychess

I'll give it a go on Sunday

CasperN avatar Aug 27 '22 17:08 CasperN

instead of trying to merge with master, I just started again

CasperN avatar Aug 29 '22 02:08 CasperN