Derek Bailey

Results 266 comments of Derek Bailey

@kenroser Sorry for the delay, I was out on paternity leave. I put a PR up with a fix.

Thanks, sorry the toil. We don't have testing in this area, so it is hard to know what breaks. Thanks for the example, I will attempt a fix.

@alexames One question, for your last example where you have `--include-prefix generated` with absolute paths, what do you expect the output to be?

Is that JSON hand written or is it what is exported?

Can you share the generated code of `CreateSortedVectorOfIntItem` for both the string an ushort keys?

I actually don't know the purpose of `FLATBUFFERS_FLATC_SCHEMA_EXTRA_ARGS`, but it should be fine to update. I would just do it for the normal flatbuffers before going into grpc extensions. Unless...

Hmm, I'm not sure that is supposed to make the `flatc` compiler. The `add_subdirectory` is just linking in the cmake rules, you will still need to explicitly make the `flatc`...

I think we need to set these flags to be private to the target (see https://cmake.org/cmake/help/latest/command/target_compile_options.html) instead of setting them in the global C++ CMAKE_CXX_FLAGS. That way they don't propagate...