Derek Bailey

It would be great if you wanted to move us over to that way, if not, I can prioritize switching over to using localized arguments.

Ok, give me a few days to find time to get it in. I'll ping you when you can rebase on top.

Just letting you know I'm currently working on this in #7222

@paulharris This PR can be started again. There should be a single location in the CMakeLists.txt to add these warnings too, and they shouldn't propagate to other targets (like the...

Looks good. If you want, you could group all the static functions and place them at the head of the file within an anonymous namespace as well, as that it...

That's fine to do the anonymous namespace.

I agree, it would be nice to have a pay for what you use model. What if this verifier is just a thin wrapper on top of the base API,...

Looks like an issue with the copy constructor for that comparator. Is there a reason to work on version 1.11.0? You are getting the latest code and building it, you...

We treat all warnings as errors as we want to produce the most correct version of flatbuffers we can. Any warnings we get from the compiler should be examined in...

Yeah, I believe protobufs does the :: preappend as well, this seems like a valid use case for justifying the increase verbosity of the generated code. Would you like to...