flatbuffers icon indicating copy to clipboard operation
flatbuffers copied to clipboard

Published 20 hours ago • verified publisher icon google

[Rust] add function to retrieve file identifier

Open rileylyman opened this issue 2 years ago • 2 comments

This adds a way for us to get the file identifier directly via Rust.

rileylyman avatar May 15 '22 01:05 rileylyman

❤️‍🔥

ghost avatar May 15 '22 01:05 ghost

Sorry for the delayed review, I was on vacation.

Broadly LGTM but,

  1. Can you add a test to tests/rust_usage_test/tests/integration_test.rs or somewhere?
  2. (optional) Imo, we should be using [u8; 4] instead of &str+ assert. Flatbuffers requires 4 characters and we may as well make it a compile-time error. This does mean buffer_has_identifier needs to be marked deprecated and we'd need a new name.

CasperN avatar May 23 '22 12:05 CasperN

@rileylyman Any desire to continue with this?

dbaileychess avatar Aug 06 '22 05:08 dbaileychess

Closing for now, feel free to reopen.

dbaileychess avatar Aug 13 '22 05:08 dbaileychess