Derek Bailey

Results 273 comments of Derek Bailey

I'm open to PRs to see how it would look. I'm not looking to implement this myself at the moment.

Related about speeding up compilation/linking: #7481 @CasperN any desire to do some of these things?

I'm not a go user, is there a way to determine in code if the machine is big/little endian? For C++ we can infer it and have macros to avoid...

That looks like a runtime check, so you'll pay costs to switch paths at runtime. Also, flatc wouldn't have this knowledge.

Yeah, my runtime concern was the "extra indirection to the correct func for the current endianness". C++ is nice that we don't have to do that indirection at runtime. If...

@vglavnyy We would like to look at this again, specifically for json. Is your last comment on this issue (https://github.com/google/flatbuffers/issues/5371#issuecomment-497772425) still the correct path to take?

So JSON doesn't support hexadecimal numbers: https://www.json.org/json-en.html So I don't think printing them out as HEX is the correct way to handle this.

Yes, the `Align(sizeof(T))` seems like it can be changed to `Align(AlignOf())` as we align to the largest type of a struct, or to the size of the item if not...

@paulovap Can you help with the kotlin issue?