[C++] LookupByKey fails for table restored from json with unsorted elements

[hanagasira]

• The following test code fails [C++, VisualStudio 2022, Windows 10, master]

void JsonParseTest()
{
  flatbuffers::Parser parser;
  TEST_EQ(parser.Deserialize(MyGame::Example::MonsterBinarySchema::data(),
                                MyGame::Example::MonsterBinarySchema::size()),
          true);

  auto jsonStr = R"(
{
  "name": "lookupTest",
  "testarrayoftables": [
    { "name": "aaa" },
    { "name": "ccc" },
    { "name": "bbb" }
  ]
}
)";
  TEST_EQ(parser.ParseJson(jsonStr), true);
  auto monster = flatbuffers::GetRoot<MyGame::Example::Monster>(parser.builder_.GetBufferPointer());

  TEST_NOTNULL(monster->testarrayoftables()->LookupByKey("aaa"));
  // The test fails here.
  TEST_NOTNULL(monster->testarrayoftables()->LookupByKey("bbb"));
  TEST_NOTNULL(monster->testarrayoftables()->LookupByKey("ccc"));
}

When restoring a table from a json file, StructDef::has_key is not set, so the elements are not sorted and the test fails

[dbaileychess]

Is that JSON hand written or is it what is exported?

[hanagasira]

This json was hand written.

The json exported from the table is already sorted and LookupByKey succeeds.