David Allison

Results 1051 comments of David Allison

Could you send a video? On my emulator: * I see a hover cursor, but not a hover color * The color is set after the click

A test fails ``` PrefsSearchBarTest > All indexed XML resIDs lead to the correct fragments on getFragmentFromXmlRes FAILED java.lang.AssertionError: com.ichi2.anki.debug:xml/preferences_reviewer_controls should match the preferenceResource of ControlsSettingsFragment Expected: but: was at...

EDIT: Github app mislead me, wasn't a re-request for me What's the re-requested review regarding? Is there anything specific you want me to look over. It doesn't look substantially changed...

Cause: https://github.com/ankidroid/Anki-Android/blob/de53c357fa4da65400d161038bc85106a352a0be/AnkiDroid/src/main/java/com/ichi2/anki/pages/AnkiServer.kt#L26-L27 Local storage is not shared if we're hosting on a dynamic port

@pganssle As far as I understand it, Anki Desktop loses localStorage once it's been closed. After the fix, AnkiDroid will do the same. If more is required, please let me...

Likely related: > Android/data directory corrupted after Pixel-to-Pixel migration (Android 16) — apps cannot create external private storage directories https://issuetracker.google.com/issues/460912704

I think it's unusual that the menus for the fragmented view are the responsibility of the fragment on the right, as it adds complexity to the logic I would expect...

It would, add a to-do and let's get this in

* https://github.com/ankidroid/Anki-Android/pull/16705

``` CardTemplateEditorTest > testDeletePendingAddExistingCardCount FAILED java.lang.NullPointerException: null cannot be cast to non-null type androidx.appcompat.app.AlertDialog at com.ichi2.anki.RobolectricTest.getAlertDialogText(RobolectricTest.kt:219) at com.ichi2.anki.CardTemplateEditorTest.testDeletePendingAddExistingCardCount(CardTemplateEditorTest.kt:467) ```