David Allison
David Allison
@krmanik Ready for review? Will you want this squashed or rebased when you're done?
> Just ran all the tests again, found that all lint tests are passing on my machine, I think lint failed due to ` @SuppressLint("StringFormatInvalid")` It's a lint failure, not...
The lint check still fails, please see the linked GitHub action, or run `./gradlew lint`
> this line will get affected in line no 747 CardTemplateEditor.java if we not keep that variable static > DeckSelectionDialog dialog = DeckSelectionDialog.newInstance(title, explanation,(selectedDeck!=null) ?selectedDeck.getDeckId():ALL_DECKS_ID,true, decks); > AnkiActivity.showDialogFragment(activity, dialog); Thanks!...
If you're going to do this, don't use regex, use the IDE
I'd like to reopen this for discussion It feels useful to have the Anki code which mirrors the python be 1:1 in all aspects. One of our constant maintenance tasks...
> @david-allison-1 Can you help by telling how should I proceed with the unit test here? The first step is to determine which commit introduced the problem. This can either...
@BrayanDSO I believe this is fixed, could you link the PR it was fixed in, and also on the linked PR
Look into `ShadowActivity`, if that doesn't help, agreed with Mike, better to have an instrumented test with a note to fix it later
Lint is failing