David Allison
David Allison
My understanding was that this change was getting rid of `findViewById` and associated `lateinit` variables. `setContentView` leads to a lot of `findViewById` calls What are the benefits/downsides of leaving them...
Handled in https://github.com/ankidroid/Anki-Android/blob/22950d9fb0cf75f9b9b938ff4f4b3726e645aaca/AnkiDroid/src/main/java/com/ichi2/anki/Reviewer.kt#L325-L331
@Jatin887 @JatinApk What's the status of this?
* Past discussion: https://github.com/ankidroid/Anki-Android/pull/19208 ---- > Deprecation issue is upstream, apparently solved in 2.3.0-Beta1 --> https://youtrack.jetbrains.com/issue/KT-80974/False-positive-deprecation-warning-on-overrides-in-Kotlin-2.2.20 > > -- is apparently only a problem in anonymous classes, local classes don't...
@criticalAY FYI
I don't think this looks good. The icon styles are now inconsistent on the buttons in the Note Editor (filled vs outline). I think this is better: (image - outlined)...
They're still inconsistent between filled and outline
The filled icons don't look good on the buttons. Filled looks better for the bottom sheet, but draw is definitely inconsistent, others may be
Personally: YES!!!! that looks MUCH better!
@snowtimeglass All OK here? I'm reopening as I thought this was good to go