David Allison
David Allison
@SanjaySargam run and debug the listed test
CI in main passes. It's likely an issue with this PR I'm not going to have time to dig deeper today
https://github.com/ankidroid/Anki-Android/blob/9c5ce7cc1e6a6cf5a6beb00a8bbe777ae080251d/AnkiDroid/src/test/java/com/ichi2/anki/RobolectricTest.kt#L215 `getLatestDialog` returns `null` causing the crash
Logs when failing ``` SLF4J: Class path contains multiple SLF4J bindings. SLF4J: Found binding in [jar:file:/Users/davidallison/.gradle/caches/transforms-4/7abe0f11969f889e91071cf394c241db/transformed/slf4j-timber-3.1-runtime.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/Users/davidallison/.gradle/caches/transforms-4/2942083a1c2f97a1213598d3cb7713d2/transformed/slf4j-timber-3.1/jars/classes.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation. SLF4J: Actual binding...
`CardTemplateNotetype.isOrdinalPendingAdd(tempModel, ordinal)` is `true` in a 'good' commit and `false` in a 'bad' commit @SanjaySargam Next step is for you to figure out why
* https://github.com/ankidroid/Anki-Android/issues/16467 I believe, not relevant to this PR
This doesn't look good visually
``` AnkiDroid Version = 2.19alpha0-debug (bdb2237a77e9617ad6c399c40a82ba65b7d2508e) Backend Version = 0.1.38-anki24.04.1 (24.04.1 ccd9ca1a8309b80bcb50ddc5d99c7ce63440bce9) Android Version = 14 (SDK 34) ProductFlavor = play Manufacturer = Google Model = sdk_gphone64_arm64 Hardware = ranchu...
Needs de-conflicting as well
@SanjaySargam If this is being rebased, please fixup the commit messages After this, I think it will be good to go. I'll do a final review