Anki-Android
Anki-Android copied to clipboard
feat: Make preferences in ControlSettings tabs searchable
Purpose / Description
- Enable search functionality for preferences under Reviews and Previews tabs in Controls settings
- Add automatic tab navigation when accessing tabbed preferences from search results
- Handle duplicate preferences with distinct context labels
Fixes
- Fixes #18216
How Has This Been Tested?
https://github.com/user-attachments/assets/3a30b363-7378-4d93-bfbf-b125e989de05
Checklist
Please, go through these checks before submitting the PR.
- [x] You have a descriptive commit message with a short title (first line, max 50 chars).
- [x] You have commented your code, particularly in hard-to-understand areas
- [x] You have performed a self-review of your own code
- [x] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
- [ ] UI Changes: You have tested your change using the Google Accessibility Scanner
A test fails
PrefsSearchBarTest > All indexed XML resIDs lead to the correct fragments on getFragmentFromXmlRes FAILED
java.lang.AssertionError: com.ichi2.anki.debug:xml/preferences_reviewer_controls should match the preferenceResource of ControlsSettingsFragment
Expected: <2132082712>
but: was <2132082704>
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
at com.ichi2.anki.preferences.PrefsSearchBarTest.All indexed XML resIDs lead to the correct fragments on getFragmentFromXmlRes(PrefsSearchBarTest.kt:71)
- 1 issue of accessibility/ease of use
- 1 issue of maintainability
Can you elaborate a bit more
EDIT: Github app mislead me, wasn't a re-request for me
What's the re-requested review regarding? Is there anything specific you want me to look over.
It doesn't look substantially changed since I last reviewed