David Allison

Duplicated on stock Google Pixel 3a on Android 11, and also on API 30 Emulator. The steps lead to a reproducible issue, but LeakCanary seems to work if AnkiDroid is...

AVD Details ``` Name: Pixel_3a_API_30 CPU/ABI: Google Play Intel Atom (x86) Path: C:\Users\David\.android\avd\Pixel_3a_API_30.avd Target: google_apis_playstore [Google Play] (API level 30) Skin: pixel_3a SD Card: 512 MB fastboot.chosenSnapshotFile: runtime.network.speed: full hw.accelerometer:...

I get a hang, then a crash only after `gradlew assembleRelease`. My use case is calling `SoundPlayer.playUrl` on an mp3 using a `http` url pointing to an IP. **Reproduction:** `...

I wouldn't say so, it fails the principle of least surprise. Searching for 'empty string' is current a no-op, rather than dismissing the search or searching for "" Check for...

Since we have the deck picker spinner, I don't think we'll want to follow that behaviour exactly. It does imply support that our 'do nothing' is incorrect

I don't think I described consistency sufficiently (sorry). I've elaborated in a review comment

Can we take this back to a GitHub issue or Discord? This is a massive undertaking. I'd struggle to find justification to accept the PR, and I don't feel this...

We do have a way to download screenshots, let's move this to: https://github.com/ankidroid/Anki-Android/issues/8621. I feel uploading screenshots is overengineering at this point - far too much that can go wrong...

> I have used https://regexr.com/6spn2 to build regex for matching broken strings. It should be added more to regex for matching more broken strings. This class/documentation may be of use....

> I think `Aapt2Util.kt` and `NonPositionalFormatSubstitutionsTest.kt` should be translated to TypeScript because regex approach may be not find errors, for e.g. `%s %s`. I will try to translate it to...