Dave Rupert
Dave Rupert
This is interesting. I like the idea of supporting `em, rem, vw` units. I would be opposed to introducing a custom unit/DSL like `pw`, however. This increases the size and...
Can you better describe the problem you're trying to fix? Also, [we now require educed test cases](https://github.com/davatron5000/FitText.js/blob/master/CONTRIBUTING.md). It looks like you're just injecting a bunch of CSS that may or...
FitText was designed to work with multiple lines of text. So I'm not really sure that this fits that use case. Maybe putting this functionality behind a `noBreak: true` option...
So whitespace nowrap, what if you wanted text to wrap to 2 lines but also wanted to maintain scalability?
Does this mean `defaults` attaches global namespace? It should probably be under `$.fn.fitText` in order to be polite. Right?
I really like this! I think it maybe makes sense to only create one `compressor` variable inside the `return $.each()` rather than having two very similar (named) variables in memory....
Thanks @Saturn2888 for the commit. This seems really specific to your current implementation and JS breakpoint management dependencies. Would you mind giving some background?
Nope. It's not `clientWidth`, it's the parent elements width.
@saintclair I appreciate your enthusiasm, I really do, but you're creating more work for me on this. You're over-engineering here and you need to just do the modification that I...
Hrmmm... This is the first time this use case has come up. I think it's maybe unique to your situation where you want to use those utility classes with the...