aragonOS icon indicating copy to clipboard operation
aragonOS copied to clipboard

Published 20 hours ago • verified publisher icon aragon

Testing improvements

Open dapplion opened this issue 4 years ago • 5 comments

Following the request on the "good first issue" https://github.com/aragon/aragonOS/issues/514, I am extending the tests covering the following items:

  • [x] Explicitly test AppProxyFactory. newAppProxyPinned(IKernel, bytes32)
  • [x] Explicitly test EVMScriptRunner.protectState modifier
  • [x] Test view methods of SafeERC20.sol

NOTE: This PR is a WIP until further questions are resolved.

dapplion avatar Jul 13 '19 20:07 dapplion

Thanks for opening this pull request! Someone will review it soon 🔍

welcome[bot] avatar Jul 13 '19 20:07 welcome[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 13 '19 20:07 CLAassistant

Coverage Status

Coverage increased (+0.9%) to 100.0% when pulling 6d84a85fce3e30c554290aaaa05969ced62b2480 on dapplion:514_testing_improvements into 0fd1ff673e160597b0cbabc1956a2a547b1c41f0 on aragon:next.

coveralls avatar Jul 13 '19 21:07 coveralls

@sohkai The Travis build on my fork's branch completes the coverage step successfully https://travis-ci.com/dapplion/aragonOS/builds/125316450. However, on your repo it doesn't, where it errors with:

Writing artifacts to ./build/contracts
Instrumenting  ./coverageEnv/contracts/acl/ACL.sol
Skipping instrumentation of  ./coverageEnv/contracts/acl/ACLSyntaxSugar.sol
Instrumenting  ./coverageEnv/contracts/acl/IACL.sol
Cleaning up...
There was a problem instrumenting ./coverageEnv/contracts/acl/IACL.sol: TypeError: Cannot read property 'stop' of null
Exiting without generating coverage...
npm ERR! code ELIFECYCLE

Do you have any clue on what might be the issue? With this last commit, coverage gets to 100.00% :)

dapplion avatar Aug 31 '19 12:08 dapplion

@cgewecke helped solve the problem and now of CI tasks complete successfully

dapplion avatar Sep 17 '19 16:09 dapplion