Lion - dapplion

Results 411 comments of Lion - dapplion

Late recap from ACDC 124 https://github.com/ethereum/pm/issues/922 | Option | Pros | Cons | | - | - | - | | Add `seen_timestamp` property to the existing event | -...

FYI @iri031 there are still some unaddressed comment

This issue should only be closed if we implement something related to the shrinkwrap strategy or if that's abandoned

I remember asking myself this when doing some PoC a long time ago that depended on `common/eth2`

The dependency on libp2p is only for these types ```rust use lighthouse_network::{types::SyncState, PeerInfo}; use lighthouse_network::{ConnectionDirection, Enr, Multiaddr, PeerConnectionStatus}; use lighthouse_network::PeerId; ```

From an offline chat with @AgeManning we suggested to: - Return the serialized ENR as a String to avoid the dependency on discv5 - Import PeerID from its own crate...

> for the 3rd point, should a new crate be created or should I put it in an existing one? You can add a new crate `network_types`

> feels like we should expose a better API via NodeBuilder for overriding the pre/post hooks more granularly, and for new system contracts, given BSC also uses it Let me...

@mattsse do you want to merge this in as-is, and have the satisfaction of reducing code once https://github.com/paradigmxyz/reth/issues/11274 lands? Or wait to merge https://github.com/paradigmxyz/reth/issues/11274 before this PR

🎉 thanks for updating it to the custom executor