dantleech
dantleech
https://github.com/phpactor/phpactor/pull/1862
have had a look at this -- I think it would be better for me to do https://github.com/phpactor/phpactor/issues/1823 which should fix this in a better way..
Will be fixed in #1855
Cherry picked your fix and tests, should work now!
Package webmozart/path-util is abandoned, you should avoid using it. Use symfony/filesystem instead.
yes we can, bit annoying that package became part of a package that has nothing to do with the Path util.
Package webmozart/path-util is abandoned, you should avoid using it. Use symfony/filesystem instead.
and it's a little but annoying as the package is used over at least 4 other packages, so not a 5 minute job.
s/are/are not ?
hmm, this variation is not supported by PHPStan, not sure if it's supported by Psalm and it is not the "standard": https://docs.phpdoc.org/3.0/guide/references/phpdoc/tags/var.html is it supported by PHPStorm? i think it...
just for context: if it's a vendor file, how does it affect users of Phpactor (assuming they are not editing the vendor file)?
hm, we could potentially add a warning diagnostic for this invalid syntax but still support it. can you add another test here? ``` diff --git a/lib/WorseReflection/Tests/Inference/variable/type_from_var_docblock_invalid.test b/lib/W> new file mode...