dantleech

Results 873 comments of dantleech
trafficstars

This library might be interesting https://github.com/phpactor/class-to-file it was made exactly for this use case I think :)

@roxma this works great :)

oh looks like @roxma [can't maintain this anymore](https://github.com/roxma/nvim-completion-manager/issues/12#issuecomment-382334422)

@phux I forked to https://github.com/phpactor/ncm-phpactor

Would it make sense to expose a method in the Phpactor plugin `phpactor#get_working_dir` and use that?

> should auto detect project root by default It doesn't detect the project root, it just uses the directory in which VIM was _initially_ loaded, I think there are too...

> In what case? 1. If there is no composer, we traverse to the root of the FS, which is weird, a refactoring tool that does dangerous things shouldn't be...

> You could take the parent .git root repository at this moment ? More edge cases - what if the project doesn't use git? git submodules? (eventually Phpactor won't care...

> If you're in a sub project, it doesn't matter if you're editting sub-project's files and treating it as a project root. I'm not sure -- I think @cmizzi mentioned...

I think it should be fine to pass the `g:phpactorInitialCwd` ? Although since the introduction of RPC, we could equally delegate the call to the Phpactor VIM plugin: ``` let...