dantleech

Results 873 comments of dantleech

> I'll get my head around this Diagnostics are an in-development feature, e.g. https://github.com/phpactor/phpactor/blob/97ff31d07cfbf20636023decb29bd43871dc250f/lib/WorseReflection/Bridge/TolerantParser/Diagnostics/MissingMethodProvider.php#L19 and they are not fully integrated, however you can test them with `phpactor worse:analyse src/Path/To/File.php` But...

looks like you need to add a `/** @phpstan-ignore-next-line */` annotation in the `UseStatementUpdater` (parser says nodes are not nullable but they really are). ~not sure why it's triggering now~...

For testing see https://github.com/phpactor/phpactor/blob/581bd4dc40250fcb2f95d1428ff1790e1ee74a21/lib/WorseReflection/Tests/Integration/Bridge/TolerantParser/Diagonstics/MissingMethodProvider/InlinedType.test - Create a test case: https://github.com/phpactor/phpactor/blob/581bd4dc40250fcb2f95d1428ff1790e1ee74a21/lib/WorseReflection/Tests/Integration/Bridge/TolerantParser/Diagonstics/MissingDocblockProviderTest.php#L9 - Run the test (it should fail and tell you to create a directory) - Put some source code in...

Will be fixed by https://github.com/phpactor/phpactor/pull/1871

Because: - the frame walker builds the frame for the AssignmentExpression - the AssignemntExpressionResolver resolves the expression (correctly) - the frame now has the missing type assigned (correctly) - the...

the 2nd is because its a child class, in this case should hceck the parent to see if there is a docblock and only suggest if there is not.

Maybe as simple as deduplicating here: https://github.com/phpactor/phpactor/blob/6b0c73e9d64dd0c353d0dc3eda09159231502ee7/lib/Extension/LanguageServerCodeTransform/LspCommand/ImportAllUnresolvedNamesCommand.php#L48

In this situation I use [FZF](https://github.com/junegunn/fzf.vim) to perform fuzzy file searches. I hit `` and that performas a fuzzy search, so f.e. `SerRequInt` would probably suggest the correct class. Not...