dantleech

Results 873 comments of dantleech
trafficstars

arguably if the parent scope already has the necessary vars, `use ($foo, $bar)` can be far easier to read than scanning the function to the end and looking for the...

It makes sense to **NOT** add the `\` on a `use Foobar`. However not so much when in a class scope, where adding the `\` **does** make sense for FQNs....

> without the leading separator it will not find the class. I only expand classes in docblocks / xml / yaml etc. How does class expansion relate to auto-completion?

Actually the autocomplete is working as expected. Without the leading `\` it is relative to the current namespace (so `Your\Namespace\Blah\Symfony\Componsen\Console\InputInterface` would be resolved or similar). Phactor could be smarted about...

where does that diagnostics dialog come from? :thinking: but yes, can probably take the anonymous class into account in this case: https://github.com/phpactor/code-transform/blob/master/lib/Adapter/WorseReflection/Transformer/AddMissingProperties.php#L99

we're basically missing anonymous class support at all -- but I think we might be able to fix this diagnostic.

i guess you are suggesting they it should respect scope? currently it will highlight all variables named `$foo` in the entire document

code is here: https://github.com/phpactor/phpactor/blob/3dadcf86a19dc6c16c8ceca2cc9c0be62867f874/lib/Extension/LanguageServerReferenceFinder/Model/Highlighter.php#L27

I think there should be a specific `use` completor which offers FQN completions ? and the current class name completor should NOT complete on `use` (unless the class is in...

> the user has started typing the use statement. This would just "work" if it was implemented in Phpactor. > the user has pasted some code not really sure what...