dantleech

Results 876 comments of dantleech

Nice, I think this should also be possible in LSP via Workspace symbol search

nice! i forgot all about this. r.e. the "walker" worse reflection got refactored alot since this extension was created. with the new type system I wonder if we could do...

> hence the createSource method. Don't hesitate if there is a cleaner way to do. could also have a directory and `ReflectorBuilder::create()->withLocator(new BruteForceLocator(__DIR__ . '/stubs'))->build()` to return the Reflector. You...

> It should be a union instead of an intersection intersection means _implementing_ both contracts. so the callable methods are all the methods on both types. the difference is that...

~yes, creating a generic `Subject` stub sounds good, although currently there is no way for extensions to add a stub (it could be done via. configuration in the short term)~...

> I also encounter a case which I think is invalid but since I just learned the true meaning of intersection I might be wrong  If I add the...

we can add a "walker": https://github.com/phpactor/phpactor/blob/3f1b550656e1f095913040db16d7a0d23e813fc0/lib/Extension/WorseReflection/WorseReflectionExtension.php . although i'm not sure how it might help, as it is for modifying (e.g. adding/removing vars) from the `Frame`. The other, currently not...

fwiw the phpstan-prophecy extension might be worth a look: https://github.com/Jan0707/phpstan-prophecy/tree/master/src as I think it's a similar problem (maybe we could have a prophecy extension too) ![image](https://user-images.githubusercontent.com/530801/169754986-91a4ad49-e38a-47fd-9d71-8c5709d319f1.png)

@DanielSiepmann if you're referring to "extensions" I've disabled that possiblity for now in favour of bundling them all into the monolith. It makes maintenance easier and gives us much more...

nope, this is about adding a new feature