dantleech

Work in progress: https://github.com/phpactor/completion/pull/14#pullrequestreview-145821052

This is by design, but the UX isn't good when encountered in an editor. Could possibly show a warning instead in these cases -- not 100% sure how.

"classic" Phpactor also has an `:ExpandClass` action in VIM, so it would make sense to add both add code actions.

This might be more to do with WorseReflection not aggregating the methods from the trait-in-the-trait. (i.e. real time, not index time)

this seems to be fixed since some refactoring a month or so back: 

yes. currently there is only an API for generating single getters: https://github.com/phpactor/code-transform/blob/master/lib/Domain/Refactor/GenerateAccessor.php The legacy RPC handler (in `lib/Extension/CodeTransformExtra/Rpc/GenerateAccessorHandler.php`) will also generate all accessors for a class. This functionality is currently...

cc @Einenlum this works for me:  did you try restarting nvim? sometimes I have issues with it geting out-of-sync

you're using the VIM "import class" (i.e. `:PhpactorImportClass`) as opposed to the LSP code action? (both work for me however) ``` NVIM v0.7.0-dev+1446-g18152cf6f Build type: RelWithDebInfo LuaJIT 2.1.0-beta3 Compilation: /usr/bin/gcc-11...

Intereseting, I wonder how deep the CRLF rabbithole goes...

The relevant code seems to be here: https://github.com/phpactor/phpactor/blob/a383cf9a8f34b515fb96865f8135155e590a2c13/lib/TextDocument/LineCol.php#L121-L125 It actively tries to handle `\r\n` - but maybe that's the issue?