dantleech

Results 873 comments of dantleech

Assuming this is no longer an issue

i think we should inherit the type from the interface `@inheritdoc` or not.

As of #1553 this is fixed in the LSP implementation

I think this should be [possible](https://github.com/phpactor/completion/blob/2347168e27a13e88418ea4dd44fc57778c2e8b93/lib/Bridge/TolerantParser/WorseReflection/WorseSignatureHelper.php#L29) (cc @camilledejoye FYI)

![image](https://user-images.githubusercontent.com/530801/111168951-7471b980-859a-11eb-9b87-d8e356fb7229.png) Can reproduce - strange it doesn't happen in VIM though: ![image](https://user-images.githubusercontent.com/530801/111169014-82273f00-859a-11eb-8ee0-293aebebd6bd.png)

There's nothing wrong with it, it's just :hankey: :smile: it was intended as a "debug" tool showing the frame etc, but that didn't really work out: it should only show...

> If you can provide relevant code and/or solution, @dantleech? It's in Worse Reflection, maybe [here](https://github.com/phpactor/worse-reflection/blob/5f138ad936cd37d88bb10e01adad45334472241b/lib/Core/Inference/SymbolContextResolver.php#L771) or [here](https://github.com/phpactor/worse-reflection/blob/5f138ad936cd37d88bb10e01adad45334472241b/lib/Core/Inference/FrameBuilder/AssignmentWalker.php#L145). Basically those positions are being assigned from the definition instead of the...

There is already possible to soft rebuild the index: ``` :command! -nargs=0 LspPhpactorReindex lua vim.lsp.buf_notify(0, "phpactor/indexer/reindex",{soft = true}) ``` will see if this fixes consistency issues, if not perioudically refreshing...