Daniel Rozenberg

Results 56 comments of Daniel Rozenberg

> Can this be implemented as a special case in the owners-bot logic that's triggered for new folders in `extensions/`? @rcebulko WDYT? I'd rather have a separate app do this...

@alanorozco this is done and deployed, right? Can we close this?

No worries, it's a familiar struggle :)

Adding to this - the CLI also doesn't recognize `.codecov.yml` in [contrast with the documentation](https://docs.codecov.com/docs/codecov-yaml#can-i-name-the-file-codecovyml)

@powerivq is this something you can help with?

Hi @amandine-trl, we'd like to merge this pull request, however the new test you've added is failing - would you please follow the [fix instructions](https://app.circleci.com/pipelines/github/ampproject/amphtml/31212/workflows/315d089e-e136-4671-b683-d1303ac4a143/jobs/678954) on the failed test, and...

@amandine-trl we're all good, thanks for the contribution!

As a workaround I found that this works: ```diff type MyType = { field: string | null; }; const schema: JSONSchemaType = { $schema: 'http://json-schema.org/draft-07/schema#', type: 'object', required: [ 'field',...

I experimented a bit by downloading the .xpi directly and changing various values. It looks the "all websites" appears as a result of the `""` in the `content_script` config of...

> However, switching to MV3 also would not solve anything, as the required permissions are the same. It would only delay the permission prompt until after the user first tries...