Daniel Rozenberg

Results 56 comments of Daniel Rozenberg

I'm seeing the same problem on my repo (https://github.com/danielrozenberg/snooze-pocket/), mine has a `master` branch

🙈 my bad... I fixed my repo. Console errors in minified code are hard to read 🙈

Update: it worked when I cloned your repo and did the same change. It just didn't work when I changed it in the already-compiled extension 🙃

Chrome only supports `chrome`, Firefox supports `browser` and `chrome` (the latter is an alias to the former), other browsers (Edge, Safari) support `browser`, I don't know if they support `chrome`...

This would require a much bigger change to the bot than I can handle, relative to the payoff (i.e., I think of it as a P3 that would require a...

@jridgewell fixit week is a perfect time to answer that question ^

I'll push work on this for the end of this week and see if I can figure out a middle ground or at least make some initial progress on this

It's a good extra step, regardless of how "important" the apps are, but don't overthink it. Unless it's a simple flag in GAE config, make this a fixit week task...

Still relevant, let's do it next fixit

It's one extra layer of security, it's definitely not required but it does tell the world we're Professionals :D