Daniel Rozenberg
Daniel Rozenberg
Sounds reasonable to me, it's really just a set of html + js files so any static files solution would work. Just need to figure out a way to keep...
> I think a more maintainable way to do this is to make the job script `visual-diff-tests.js` take a command line arg, and parametrize the job definition in `config.yml`. #32808...
Since both jobs use the same Percy write-only token, they'll both end up in the same project, and Percy will only report one as a status to GitHub - whichever...
Again, no strong feelings either way. The overhead having two tokens/projects isn't that serious though, and we already discussed having separate projects for Chrome and for Firefox once Puppeteer fully...
Looks like someone with OWNERS approval had to re-approve this, which I just did. Go ahead team and submit this when ready!
Looks like there was a change in Chrome that breaks some of these tests. The breakage results from a difference here: https://github.com/ampproject/amphtml/blob/main/extensions/amp-skimlinks/0.1/test/helpers.js#L13-L18 In Chrome 119, creating an `` element inside...
This PR updates core *dependencies* (not devDependencies) so I think we should have a thorough review here :)
> This PR updates core _dependencies_ (not devDependencies) so I think we should have a thorough review here :) Ping @erwinmombay / @ychsieh - I want to get at least...
Woohoo! Finally managed to get this PR green! @erwinmombay - there are bundle-size changes worth looking into
Bump @erwinmombay / @ychsieh - some serious bundle size changes. PTAL? Should we try to mitigate those?