Daniel Rozenberg

Results 56 comments of Daniel Rozenberg

I created this [minimal example](https://gist.github.com/danielrozenberg/efb8d87b5d67fdd008a276d15ea09ff8) of how the `` permission can be made to be optional while still retaining the same functionality Basically you can register and unregister content scripts...

I'd be happy to send PRs for this over the next few weeks as time permits. Let's wrap up the move to MV3 first and then move on to removing...

> If I understand that correctly, yeah it could be. The old emoji "keyword" basically was a search engine. Or in MV3 they have a different mechanism? I think this...

> Update the context menu Done (76f29f5) - I noticed that context menus were being [removed](https://github.com/rugk/awesome-emoji-picker/blob/main/src/background/modules/ContextMenu.js#L41) before being added/re-added, but it's still better to do this once on install/upgrade instead...

It looks like our tests are broken because of an issue with the most recent release. @erwinmombay is working on fixing it. Once that's fixed and the tests pass on...

@powerivq @erwinmombay Three tests get broken by this update. Two of them are easy fixes that don't seem to have any major effect, but one of them is a bit...