✨ add validation for amp-social-share in amp-story
Closes #40014 Enable amp-social-share component within amp-story-page.
Allowing the addition of a the native social sharing component within the body of an amp-story-page. For example, this would allow us to add a highly visible call-to-action, such as "Share this content" on the final page of the story.
@ychsieh could you take a look at this?
Thanks for proposing the change! Could you include a screenshot and add the example html code in examples/amp-story?
The screenshot corresponding to the added example
I built amp-story-social-share.html locally but cannot see the button shown in your screenshot. Could you double check?
Hi, I updated my example to add other cases than system share. Now, you should now be able to see at least the first three buttons. I think you may not be able to see the button because the sharing function is not activated in your browser. If you use chrome you maybe can check the web-share flag and set it to enabled if its not.
Hi, I wanted to check in regarding the status of the merge request. Could you please let me know if it's ready to be merged and if there’s an estimated timeline for when that might happen?
Thank you for your help!
You need owners approval. Adding @mszylkowski.
Hi @amandine-trl, we'd like to merge this pull request, however the new test you've added is failing - would you please follow the fix instructions on the failed test, and rebase this on the latest main branch?
Hi @danielrozenberg, The code has been updated and the issue is resolved. Let me know if there's anything else you'd like me to verify before merging.
@amandine-trl we're all good, thanks for the contribution!