Automatically post checklist comment for new components

[alanorozco]

When a PR includes a new folder in extensions/, @ampprojectbot will post a checklist as a comment:

It looks like you're submitting a new extension. 👁️📎👁️

Please make sure you're following the contribution guidelines. These steps need to be completed before code review:

• [ ] This extension has an intent-to-implement issue (I2I) that is attached to this pull request. It documents:
  • [ ] the features the extension provides
  • [ ] the attributes the element uses, if any
  • [ ] how attributes are validated
  • [ ] how the page is modified: "my component creates an <iframe> that loads $URL"
  • [ ] if a video player, it explains purpose according to video component policy  
• [ ] The I2I issue tags a working group:
  • if the extension is an ad type, or an integration for analytics: @ampproject/wg-ads-and-analytics
  • otherwise: @ampproject/wg-ui-and-a11y.  
• [ ] The I2I issue has been approved during a design review.

It could block OWNERS check:

After you've checked all items in this list, an appropriate reviewer will be automatically assigned.

or:

• [ ] This pull request adds an extension/amp-new-extension/OWNERS file that includes:
  • [ ] yourself (username)
  • [ ] the relevant working group (like ampproject/wg-ads-and-analytics)

/to @ampproject/wg-infra

[rsimha]

Can this be implemented as a special case in the owners-bot logic that's triggered for new folders in extensions/? @rcebulko WDYT?

[danielrozenberg]

Can this be implemented as a special case in the owners-bot logic that's triggered for new folders in extensions/? @rcebulko WDYT?

I'd rather have a separate app do this - let's not mix in unrelated features into the owners-bot just because these two apps will share some lines of code (we can always move those lines of code into a common module)

Starting a new Probot app is extemely cheap and easy (like, ~1-2 hours for all the boilerplate and infra, in our experience)

[rsimha]

rsimha left the conversation

J/K, separate app SGTM. 😃

[rcebulko]

+1, new apps are indeed extremely cheap. This one would be an excellent candidate for Cloud Functions

[danielrozenberg]

@alanorozco this is done and deployed, right? Can we close this?

[alanorozco]

@danielrozenberg Not done, I deployed a local copy only. Sorry for slow response on this, been unable to prioritize it :/

[danielrozenberg]

No worries, it's a familiar struggle :)