📦 Update dependency chromedriver to v130

Open renovate[bot] opened this issue 1 year ago • 1 comments

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
chromedriver	`119.0.1` -> `130.0.0`

See all other Renovate PRs on the Dependency Dashboard

How to resolve breaking changes

This PR may introduce breaking changes that require manual intervention. In such cases, you will need to check out this branch, fix the cause of the breakage, and commit the fix to ensure a green CI build. To check out and update this PR, follow the steps below:

# Check out the PR branch
git checkout -b renovate/major-chrome-and-chromedriver main
git pull https://github.com/ampproject/amphtml.git renovate/major-chrome-and-chromedriver

# Directly make fixes and commit them
amp lint --fix # For lint errors in JS files
amp prettify --fix # For prettier errors in non-JS files
# Edit source code in case of new compiler warnings / errors

# Push the changes to the branch
git push [email protected]:ampproject/amphtml.git renovate/major-chrome-and-chromedriver:renovate/major-chrome-and-chromedriver

Release Notes

giggio/node-chromedriver (chromedriver)

Configuration

📅 Schedule: Branch creation - "after 12am every weekday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Mar 21 '24 13:03 renovate[bot]

Looks like there was a change in Chrome that breaks some of these tests. The breakage results from a difference here:

https://github.com/ampproject/amphtml/blob/main/extensions/amp-skimlinks/0.1/test/helpers.js#L13-L18

In Chrome 119, creating an <a> element inside the FakeWindow's Document, then setting its anchor.href to a schema-agnostic URL (e.g., anchor.href = '//a.com/';, ancho.href = 'a.com';) correctly changes the anchor.hostname field as well.

In Chrome 120, these URLs result in an empty string in anchor.hostname.

This issue only manifests itself inside the FakeWindow, it works as expected in a real window.

The one thing I noticed is that win.document.baseURI is set to http://localhost:6789/path/to/test/file.html in 119, and to about:blank in 120. I'm not sure if this is relevant, or how to continue this investigation

Help! @ychsieh @erwinmombay

Mar 21 '24 18:03 danielrozenberg