amphtml
amphtml copied to clipboard
🐛 Set `latestVersion` for `amp-story-audio-sticker`
Tools like the AMP Optimizer require latestVersion
to correctly import extensions with the correct version.
I thought https://github.com/ampproject/amp-toolbox/pull/1357 was enough to support amp-story-audio-sticker
there, but turns out it wasn't.
All other extensions already have latestVersion
set, so it makes sense for amp-story-audio-sticker
to set it too.
Once this is merged, I'll submit a follow-up to https://github.com/ampproject/amp-toolbox/pull/1357 on the toolbox repo.
/cc @erwinmombay
sorry missed this. approved
Awesome, thanks. I just updated the branch so this should be ready for merge now.
Note that the failing Circle CI tests seem unrelated as they happen on main
as well.
@erwinmombay @ychsieh Mind merging this one? :-)
Seems like Percy visual test is failing. Please re-run.
Seems like Percy visual test is failing. Please re-run.
I just did, but to no avail. There's a snapshot that's missing on main
but is not missing here 🤷
Maybe just approve the build on Percy?
@ychsieh OK, Percy is happy now 🤷 THis should be ready.
Could you sync and push to rerun the owners check(which also rerun everything tho)?
That doesn't help with the owners check it seems
Looks like someone with OWNERS approval had to re-approve this, which I just did. Go ahead team and submit this when ready!