amphtml icon indicating copy to clipboard operation
amphtml copied to clipboard

🐛 Set `latestVersion` for `amp-story-audio-sticker`

Open swissspidy opened this issue 11 months ago • 1 comments

Tools like the AMP Optimizer require latestVersion to correctly import extensions with the correct version.

I thought https://github.com/ampproject/amp-toolbox/pull/1357 was enough to support amp-story-audio-sticker there, but turns out it wasn't.

All other extensions already have latestVersion set, so it makes sense for amp-story-audio-sticker to set it too.

Once this is merged, I'll submit a follow-up to https://github.com/ampproject/amp-toolbox/pull/1357 on the toolbox repo.

swissspidy avatar Mar 21 '24 14:03 swissspidy

/cc @erwinmombay

swissspidy avatar Mar 21 '24 14:03 swissspidy

sorry missed this. approved

erwinmombay avatar Apr 01 '24 21:04 erwinmombay

Awesome, thanks. I just updated the branch so this should be ready for merge now.

Note that the failing Circle CI tests seem unrelated as they happen on main as well.

swissspidy avatar Apr 02 '24 08:04 swissspidy

@erwinmombay @ychsieh Mind merging this one? :-)

swissspidy avatar Apr 15 '24 08:04 swissspidy

Seems like Percy visual test is failing. Please re-run.

ychsieh avatar Apr 15 '24 13:04 ychsieh

Seems like Percy visual test is failing. Please re-run.

I just did, but to no avail. There's a snapshot that's missing on main but is not missing here 🤷

Screenshot 2024-04-15 at 16 03 29

Maybe just approve the build on Percy?

swissspidy avatar Apr 15 '24 14:04 swissspidy

@ychsieh OK, Percy is happy now 🤷 THis should be ready.

swissspidy avatar May 02 '24 08:05 swissspidy

Could you sync and push to rerun the owners check(which also rerun everything tho)?

ychsieh avatar May 02 '24 19:05 ychsieh

That doesn't help with the owners check it seems

swissspidy avatar May 02 '24 20:05 swissspidy

Looks like someone with OWNERS approval had to re-approve this, which I just did. Go ahead team and submit this when ready!

danielrozenberg avatar May 02 '24 20:05 danielrozenberg