Damien L-G comments

Results 492 comments of


                                            Damien L-G

Desul atomics: Add 128bit CAS for >CC90 on NVIDIA

Please post atomic_{fetch_op, op_fetch} timings before and after as well.

port STREAM benchmark to perf_test

OK then please address Maarten's comments and we should be good.

Deprecate `Random_XorShift{64,1024}_Pool::init`

Please add this to the 5.0 changelog and update the documentation as appropriate.

Add Random perf test

I only looked at one somewhat random build (Fedora+HPX+RelWithDebInfo) in the CI and the benchmark takes 90s more than what I could see in another PR. I am not thrilled...

Add Random perf test

> Each scalar type takes about 8s to run, and there are 16 such tests, for a total of about 2 minutes of additional tests. @crtrott please confirm that you...

FP16 nextafter does not raise math_errhandling

You could post the diff with a patch that adds error handling on the host side for posterity.

Diagnose illegal usage before initialize or after finalize

I am glad you are looking Stan because the big elephant in the room will be execution spaces... Do you store these as static data member like you were doing...

Random number pool generators always initialized using default execution space instance

We need to add a constructor and an `init()` overload that take an execution space argument. > If it's a simple matter of adding new constructors, I'd be willing to...

Add support for SpacemiT K60 (RISC-V)

> @dalg24 do we have a clear idea of how we name these though? Some of the ARM ones are just `ARMVX_PRODUCT` others are `ARMVX`? On the other hand most...

Add support for SpacemiT K60 (RISC-V)

Retest this please (worried about the format)